Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Problem] Docker install NNPACK fails to build #13871

Closed
Liam-Sturge opened this issue Jan 30, 2023 · 1 comment
Closed

[CI Problem] Docker install NNPACK fails to build #13871

Liam-Sturge opened this issue Jan 30, 2023 · 1 comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure

Comments

@Liam-Sturge
Copy link
Contributor

Unable to install NNPACK during execution of the script ubuntu_install_nnpack.sh due to CMake build error.

The cause of this issue is due to a recent change in the external dependency pytorch/cpuinfo, which renamed the default branch to main. The NNPACK dependency has not been updated to point to the new branch in DownloadCpuinfo.cmake.

Issue has been raised for NNPACK here.

Expected behavior

Cmake should successfully build NNPACK and install it on the Docker image.

Actual behavior

build fails with the following error:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
NNPACK_CLOG_CONTRIB_LIB
    linked by target "tvm_runtime" in directory /workspace
    linked by target "tvm" in directory /workspace
NNPACK_CONTRIB_LIB
    linked by target "tvm_runtime" in directory /workspace
    linked by target "tvm" in directory /workspace
NNPACK_CPUINFO_CONTRIB_LIB
    linked by target "tvm_runtime" in directory /workspace
    linked by target "tvm" in directory /workspace
NNPACK_PTHREAD_CONTRIB_LIB
    linked by target "tvm_runtime" in directory /workspace
    linked by target "tvm" in directory /workspace

Steps to reproduce

This issue can be replicated in a local environment when using ubuntu_install_nnpack.sh to check out and build the latest version of NNPACK in a Docker container.

Triage

Please refer to the list of label tags here to find the relevant tags and add them below in a bullet format (example below).

  • needs-triage
  • dev:ci
@Liam-Sturge Liam-Sturge added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure labels Jan 30, 2023
Liam-Sturge added a commit to Liam-Sturge/tvm that referenced this issue Jan 30, 2023
@Liam-Sturge
NNPACK build issue workaround
8476e7f 
There is currently a problem building and installing NNPACK using the
script `ubuntu_install_nnpack.sh`. The build fails to complete with
CMake errors, complaining about missing libraries.

This issue is due to a change in the imported dependency pytorch/cpuinfo
that has moved the default branch name to 'main'.

This patch has been submitted as a workaround to the issue raised at
apache#13871
@Liam-Sturge Liam-Sturge mentioned this issue Jan 30, 2023
Merged
ashutosh-arm pushed a commit that referenced this issue Jan 31, 2023
@Liam-Sturge
[CI] NNPACK build issue workaround (#13873)
5e652c1 
NNPACK build issue workaround

There is currently a problem building and installing NNPACK using the
script `ubuntu_install_nnpack.sh`. The build fails to complete with
CMake errors, complaining about missing libraries.

This issue is due to a change in the imported dependency pytorch/cpuinfo
that has moved the default branch name to 'main'.

This patch has been submitted as a workaround to the issue raised at
#13871
Liam-Sturge added a commit to Liam-Sturge/tvm that referenced this issue Feb 3, 2023
@Liam-Sturge
Revert the changes for NNPACK build issue
12b611b 
This patch undoes the change that was put in place to prevent the build
and installation of NNPACK from failing due to a renaming of the default
branch to main by the NNPACK external dependency cpuinfo.

See apache#13871

The issue has been fixed at the source by PR apache#214, so the change to
`ubuntu_install_nnpack.sh` is no longer required:

Maratyszcza/NNPACK#214
@Liam-Sturge Liam-Sturge mentioned this issue Feb 3, 2023
Merged
driazati pushed a commit that referenced this issue Feb 7, 2023
@Liam-Sturge
Revert the changes for NNPACK build issue (#13913)
60fcb0d 
This patch undoes the change that was put in place to prevent the build and installation of NNPACK from failing due to a renaming of the default branch to main by the NNPACK external dependency cpuinfo.

See #13871

The issue has been fixed at the source by PR #214 which is now merged in to NNPACK, so the change to `ubuntu_install_nnpack.sh` is no longer required:

Maratyszcza/NNPACK#214
@Liam-Sturge
Copy link
Contributor Author

Issue was resolved by PR Maratyszcza/NNPACK#214.

fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this issue Mar 27, 2023
@Liam-Sturge @fzi-peccia
[CI] NNPACK build issue workaround (apache#13873)
f258e2c 
NNPACK build issue workaround

There is currently a problem building and installing NNPACK using the
script `ubuntu_install_nnpack.sh`. The build fails to complete with
CMake errors, complaining about missing libraries.

This issue is due to a change in the imported dependency pytorch/cpuinfo
that has moved the default branch name to 'main'.

This patch has been submitted as a workaround to the issue raised at
apache#13871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Liam-Sturge