Fix grad test

apache · Nov 6, 2020 · d51a206 · d51a206
1 parent eb40a5e
commit d51a206
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/python/tvm/relay/testing/__init__.py b/python/tvm/relay/testing/__init__.py
@@ -143,6 +143,8 @@ def check_grad(
                         break
             grads = tmp
 
+        assert len(grads) > 0, "You must test at least one gradient."
+
         # Get numeric gradients for each dimension of each param, using two-sided approximation.
         approx_grads = []
         for x in test_inputs:

diff --git a/python/tvm/topi/scatter.py b/python/tvm/topi/scatter.py
@@ -294,7 +294,7 @@ def gen_ir(data_ptr, indices_ptr, out_ptr):
                         )
                     )
                     offset *= shape[l]
-                out[index] = data[i * fused_data_dimension + j]
+                out[index] += data[i * fused_data_dimension + j]
 
         return ib.get()
 

diff --git a/tests/python/relay/test_op_grad_level3.py b/tests/python/relay/test_op_grad_level3.py
@@ -122,8 +122,8 @@ def test_gather_nd_grad():
     indices = relay.var("indices", relay.TensorType((2, 4), "int64"))
     fwd = relay.Function([data, indices], relay.gather_nd(data, indices))
     data_np = np.random.rand(2, 3).astype("float64")
-    indices_np = np.array([[0, 1, 1, 0], [0, 1, 2, 1]]).astype("int64")
-    check_grad(fwd, inputs=[data_np, indices_np], test_inputs=indices_np)
+    indices_np = np.array([[0, 1, 1, 0], [0, 1, 0, 0]], dtype="int64")
+    check_grad(fwd, inputs=[data_np, indices_np], test_inputs=[data_np])
 
 
 if __name__ == "__main__":