Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tomcat log directory #7995

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

ericholguin
Copy link
Contributor

This PR creates the tomcat log directory if it doesn't exist.

Related: #7979


Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not associate the directory with the tomcat RPM (it's not listed if someone runs rpm -ql tomcat).

See how #7979 declares and creates the /var/log/traffic_monitor directory:

https://github.com/apache/trafficcontrol/pull/7979/files#diff-cca29d2cda617746476aa5bad0346e1546ede2e86814734450f7e190e6b596ec

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zrhoffman zrhoffman merged commit c7edc8a into apache:master Apr 17, 2024
14 checks passed
@zrhoffman zrhoffman added Traffic Router related to Traffic Router logging related to logging infrastructure labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging related to logging infrastructure Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants