Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect display of delivery services for an ORG server #7957

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix incorrect display of delivery services for an ORG server #7957

merged 2 commits into from
Mar 6, 2024

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Mar 6, 2024 •
edited
Loading

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run TO and TP
List the delivery services assigned to an ORG server
Only those DS's should show up that are present in the deliveryservice_server table

Do the same test for other types of servers, and make sure that topologies and required_capabilities are respected

If this is a bugfix, which Traffic Control versions contained the bug?

8.0.0

PR submission checklist

srijeet0406 and others added 2 commits March 6, 2024 09:39
@srijeet0406 @rimashah25
Fix incorrect display of delivery services for an ORG server
63e6cd9 
add changelog
code review
---------
Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com>
@rimashah25
Updated changelog
e9ab617
@rimashah25 rimashah25 marked this pull request as ready for review March 6, 2024 16:52
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 29.23%. Comparing base (dc995a9) to head (e9ab617).
Report is 1 commits behind head on master.

Files Patch % Lines
...ffic_ops_golang/deliveryservice/servers/servers.go 0.00% 17 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7957      +/-   ##
============================================
+ Coverage     26.29%   29.23%   +2.94%     
  Complexity       98       98              
============================================
  Files           738      859     +121     
  Lines         85719    91276    +5557     
  Branches         90      998     +908     
============================================
+ Hits          22537    26683    +4146     
- Misses        61094    62439    +1345     
- Partials       2088     2154      +66
Flag Coverage Δ
golib_unit 45.93% <ø> (ø)
grove_unit 4.60% <ø> (ø)
t3c_unit 4.82% <ø> (ø)
traffic_monitor_unit 20.67% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.54% <0.00%> (+0.04%) ⬆️
traffic_portal_v2 74.36% <ø> (?)
traffic_stats_unit 10.16% <ø> (ø)
unit_tests 26.52% <0.00%> (+3.38%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rimashah25 rimashah25 requested a review from zrhoffman March 6, 2024 19:04
@rimashah25 rimashah25 added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version medium impact impacts a significant portion of a CDN, or has the potential to do so low difficulty the estimated level of effort to resolve this issue is low labels Mar 6, 2024
@zrhoffman zrhoffman removed the low difficulty the estimated level of effort to resolve this issue is low label Mar 6, 2024
zrhoffman
zrhoffman approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zrhoffman zrhoffman merged commit 0839096 into apache:master Mar 6, 2024
83 checks passed
@rimashah25 rimashah25 deleted the bugfix/ds-orgserver branch March 6, 2024 19:35
rimashah25 added a commit that referenced this pull request Mar 6, 2024
@rimashah25
Fix incorrect display of delivery services for an ORG server (#7957)
89450b3 
Co-authored-by: Chatterjee, Srijeet <srijeet_chatterjee@comcast.com>

(cherry picked from commit 0839096)
rimashah25 added a commit to rimashah25/trafficcontrol that referenced this pull request Mar 20, 2024
@rimashah25
Fix incorrect display of delivery services for an ORG server (apache#…
ff89b3a 
…7957)
zrhoffman added a commit that referenced this pull request Mar 20, 2024
@rimashah25 @asf-ci-trafficcontrol
@zrhoffman @dependabot
Changes for ATC 8.0.1 release (#7969)
cb8dba7 
* Update Chromedriver Versions (#7931)

* Update Go version to 1.21.7 (#7935)

* Update Chromedriver Versions (#7941)

Update chromedriver

(cherry picked from commit 8d1b4e3)

* Update Go version to 1.22.0 (#7940)

* Update Chromedriver Versions (#7942)

Update chromedriver

(cherry picked from commit 578f04e)

* Update Chromedriver Versions (#7949)

Update chromedriver

(cherry picked from commit f91c341)

* Update Chromedriver Versions (#7950)

Update chromedriver

(cherry picked from commit a423170)

* Bump ip from 1.1.8 to 1.1.9 in /experimental/traffic-portal/build (#7945)

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 6c6eebc)

* Bump es5-ext from 0.10.62 to 0.10.64 in /experimental/traffic-portal (#7951)

Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.62...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit e05e709)

* Update Chromedriver Versions (#7954)

Update chromedriver

(cherry picked from commit 1464dc2)

* Update Go version to 1.22.1 (#7955)

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
(cherry picked from commit dc995a9)

* Fix incorrect display of delivery services for an ORG server (#7957)

* Update Chromedriver Versions (#7963)

Update chromedriver

(cherry picked from commit 26a2f6a)

* Changes for ATC 8.0.1 release.

* Remove cypress node dependency

* Updated changelog

* Updated node dependencies

* Removing minor change from PR 7957

* Removing minor change from PR 7553

---------

Co-authored-by: asf-ci-trafficcontrol <127552316+asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman approved these changes

Assignees
No one assigned
Labels
medium impact impacts a significant portion of a CDN, or has the potential to do so regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rimashah25 @zrhoffman @srijeet0406