Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tp bugfixes #7879

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Dec 4, 2023


Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Portal

What is the best way to verify this PR?

In TO, curl the deliveryservices endpoint to test for query param requiredCapability

In TP,

  1. Go to Server Capabilities tab, click on a capability and test View Delivery Services button. It should the correct DS for a given capability.
  2. For DS Table, added Required Capability(ies) column.. test to see if you can select or deselect the field.
  3. On the federations list, the Delivery Service column is not being populated.
  4. On the cache group listing (Click on the icon to view servers assigned to a cache group) the CDN column is not being populated.
  5. On Assign multiple server to a capability, cdn name was not populated.
  6. Right click on a DS, click to verify the following two links work, open DS_name in new tab and Edit.

With these fixes, columns should be populated and buttons, links should work.

If this is a bugfix, which Traffic Control versions contained the bug?

8.0.0

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review December 4, 2023 20:32
@rimashah25 rimashah25 requested a review from zrhoffman December 4, 2023 20:32
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80255a0) 29.98% compared to head (73ae8a1) 33.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7879      +/-   ##
============================================
+ Coverage     29.98%   33.83%   +3.85%     
  Complexity       98       98              
============================================
  Files           605      314     -291     
  Lines         79591    31093   -48498     
  Branches        970       90     -880     
============================================
- Hits          23863    10520   -13343     
+ Misses        53732    19555   -34177     
+ Partials       1996     1018     -978     
Flag Coverage Δ
golib_unit 53.85% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.88% <ø> (ø)
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_unit ?
traffic_portal_v2 ?
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 32.07% <ø> (+2.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rimashah25 rimashah25 changed the title Bugfix/minor tp fixes Minor tp bugfixes Dec 4, 2023
@rimashah25 rimashah25 requested a review from shamrickus December 4, 2023 20:46
* Updated CHANGELOG.md

* Updated based on review comment as well as removed deleteServerCapability button(DS table) and menu-option(right click)
…pache#7718

Updated TP field name (cdn) in server capability and updated changelog
@rimashah25 rimashah25 force-pushed the bugfix/minor-tp-fixes branch from 60ba9ee to 73ae8a1 Compare December 4, 2023 21:49
@zrhoffman zrhoffman merged commit 5c45a95 into apache:master Dec 4, 2023
42 checks passed
@rimashah25 rimashah25 deleted the bugfix/minor-tp-fixes branch December 4, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants