Use RFC 3339 for lastUpdated timestamp in /server_server_capabilities #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7744 +/- ##
=============================================
- Coverage 65.05% 32.07% -32.98%
Complexity 98 98
=============================================
Files 314 712 +398
Lines 12365 81475 +69110
Branches 907 965 +58
=============================================
+ Hits 8044 26134 +18090
- Misses 3968 53195 +49227
- Partials 353 2146 +1793
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 367 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kdamichie
suggested changes
Aug 28, 2023
| func (to *Session) GetServerServerCapabilities(opts RequestOptions) (tc.ServerServerCapabilitiesResponse, toclientlib.ReqInf, error) { | ||
| var resp tc.ServerServerCapabilitiesResponse | ||
| func (to *Session) GetServerServerCapabilities(opts RequestOptions) (tc.ServerServerCapabilitiesResponseV5, toclientlib.ReqInf, error) { | ||
| var resp tc.ServerServerCapabilitiesResponseV5 |
There was a problem hiding this comment.
Suggestion: GetServerServerCapabilities should probably be GetServerServerCapabilitiesV5
There was a problem hiding this comment.
We don't want V5 in the struct method name, since this is already the v5 version of the Session struct
There was a problem hiding this comment.
Verified v5 servers_server_capability_test.go DOES test the new code.
73fd4c3 to
c2e7652
Compare
c2e7652 to
931be5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #7743 by using the timestamp format specified in RFC 3339 for the
lastUpdatedfield of the/api/5.0/server_server_capabilitiesendpoint.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the server_server_capabilities API tests
PR submission checklist