Update timestamp for Delivery service Request Comment to match RFC3339 format #7570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7570 +/- ##
=============================================
- Coverage 64.80% 30.30% -34.51%
Complexity 98 98
=============================================
Files 201 793 +592
Lines 8158 83427 +75269
Branches 898 898
=============================================
+ Hits 5287 25281 +19994
- Misses 2689 56026 +53337
- Partials 182 2120 +1938
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 592 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| deliveryServiceRequestComments := []tc.DeliveryServiceRequestCommentV5{} | ||
| query := selectQuery() + where + orderBy + pagination | ||
| rows, err := inf.Tx.NamedQuery(query, queryValues) |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources
jagan-parthiban
suggested changes
Jun 20, 2023
traffic_ops/traffic_ops_golang/deliveryservice/request/comment/comments.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/request/comment/comments.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/request/comment/comments.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/request/comment/comments.go
Outdated
Show resolved
Hide resolved
|
Verified Locally. All Good. |
jagan-parthiban
approved these changes
Jun 23, 2023
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jun 24, 2023
…9 format (apache#7570) * wip * add remaining methods * Add changelog, fix formatting * code review comments * add nano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It changes the returned timestamp formats to RFC3339, for Delivery Service Request Comments in API 5.0 of Traffic Ops.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the unit/ API tests pass
Run TO and make CRUD requests against API 5.0 for Delivery Service Request Comments.
Ensure the timestamps are returned in RFC3339 format.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist