Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds missing read permissions to roles: r/o, portal, federation, stee… #7343

Merged
merged 2 commits into from
Mar 13, 2023
Merged

adds missing read permissions to roles: r/o, portal, federation, stee… #7343

merged 2 commits into from
Mar 13, 2023

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Feb 6, 2023 •
edited
Loading

…ring and operations

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run database migrations and then ensure the operations, portal, read-only, federation, and steering roles all have the following permissions:

  • ACME:READ
  • CDNI-ADMIN:READ
  • CDNI-CAPACITY:READ

PR submission checklist

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops bug something isn't working as intended database relating to setup/installation/structure of the Traffic Ops database permissions Dealing with roles/permissions/tenancy labels Feb 6, 2023
zrhoffman
zrhoffman approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some routes like GET /acme_accounts/providers require admin priv level and no perms other than ACME:READ. So granting it to roles like read-only, operations, etc. should be okay as long as the priv level on roues like that one is not relaxed.

@zrhoffman zrhoffman merged commit 2e397e4 into apache:master Mar 13, 2023
@mitchell852 mitchell852 mentioned this pull request Jun 26, 2023
Merged
4 tasks
@ocket8888 ocket8888 mentioned this pull request Jul 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman approved these changes

Assignees
No one assigned
Labels
bug something isn't working as intended database relating to setup/installation/structure of the Traffic Ops database permissions Dealing with roles/permissions/tenancy Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell852 @zrhoffman