-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traffic Portal configuration option for Delivery Service active flags #7296
Traffic Portal configuration option for Delivery Service active flags #7296
Conversation
Can you help me understand what this does @ocket8888 ? exposeInactive = true will display 3 options? active, primed, AND inactive ^^ is that correct? |
While reviewing and testing, this is what I noticed: |
The old notion of "inactive" is what is known as "primed" in APIv5. True "INACTIVE" is not available prior to that version, so when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Tested the configurable variable exposeInactive
for both values: true
& false
and the dropdown for DS Active Flag changes accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some test coverage for this, but I won't hold up the PR for it.
@ocket8888 - arent there a bunch of DS tables as well that will still say "primed"? |
This PR adds a new configuration option for Traffic Portal that allows exposing the new DS Active flag states. Disabled by default.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Set
exposeInactive
in the Traffic Portal Properties file tofalse
andtrue
and make sure each respective behavior works as expected.PR submission checklist