Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Portal configuration option for Delivery Service active flags #7296

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

ocket8888
Copy link
Contributor

This PR adds a new configuration option for Traffic Portal that allows exposing the new DS Active flag states. Disabled by default.


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Set exposeInactive in the Traffic Portal Properties file to false and true and make sure each respective behavior works as expected.

PR submission checklist

  • This PR doesn't need tests
  • This PR doesn't have documentation because TP configuration options are not documented
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1 configuration related to configuration - not limited to any one component low impact affects only a small portion of a CDN, and cannot itself break one labels Jan 18, 2023
@mitchell852
Copy link
Member

Can you help me understand what this does @ocket8888 ?

exposeInactive = true will display 3 options? active, primed, AND inactive
exposeInactive = false will display 2 options? active, primed but NOT inactive

^^ is that correct?

@rimashah25
Copy link
Contributor

rimashah25 commented Jan 19, 2023

Can you help me understand what this does @ocket8888 ?

exposeInactive = true will display 3 options? active, primed, AND inactive exposeInactive = false will display 2 options? active, primed but NOT inactive

^^ is that correct?

While reviewing and testing, this is what I noticed:
exposeInactive= true, displays (expected with APIv5)
image

exposeInactive= false displays (as we see today)
image

@ocket8888
Copy link
Contributor Author

The old notion of "inactive" is what is known as "primed" in APIv5. True "INACTIVE" is not available prior to that version, so when exposeInactive is true, it'll show all three Active States, and when it's false it'll show ACTIVE and PRIMED - but PRIMED will be labeled "Inactive".

Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Tested the configurable variable exposeInactive for both values: true & false and the dropdown for DS Active Flag changes accordingly.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some test coverage for this, but I won't hold up the PR for it.

@zrhoffman zrhoffman merged commit 51ab760 into apache:master Jan 19, 2023
@mitchell852
Copy link
Member

@ocket8888 - arent there a bunch of DS tables as well that will still say "primed"?

@ocket8888 ocket8888 deleted the tp/configurable-ds-active-flags branch January 19, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration related to configuration - not limited to any one component low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants