Fix shared usernames display while retrieving CDN locks #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7231 +/- ##
============================================
- Coverage 28.36% 25.95% -2.41%
Complexity 98 98
============================================
Files 617 505 -112
Lines 69195 66100 -3095
Branches 90 90
============================================
- Hits 19624 17158 -2466
+ Misses 47760 47291 -469
+ Partials 1811 1651 -160
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
approved these changes
Dec 7, 2022
... but what does it do, then? |
it does what the title says :) |
|
It just says it fixed it, but I don't even know what the problem was in the first place |
I have updated the description. |
|
Cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue.
While locking mutiple CDNs, the "shared usernames" field seems to be wrongly populated, wherein, the list shows up as a combined list of shared users from all the CDNs. This PR fixes that behavior.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests pass.
Lock multiple CDNs and share the locks amongst other users.
Make sure TP displays the CDN locks notifications correctly.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist