Remove wrapper around response object #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the APIv4 tests are expecting the wrapped format. |
ocket8888
approved these changes
Jul 15, 2022
4 tasks
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Remove wrapper around response object * Add CHANGELOG entry Co-authored-by: Taylor Frey <taylor_frey@comcast.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6795
The API response incorrectly adds an additional response and alert wrapper. The API will now return a response as documented at /federations/{{id}}/federation_resolvers
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Federations can only be accessed via the API (or the client libraries). Attempt to POST a body with contents similar to:
{ "fedResolverIds": [1], "replace": true }to the
federations/{{id}}/federation_resolversendpoint where theresolverIdsmatches existing resolvers and the{{id}}matches an existing federation.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist