Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated success message (curl and TP) for deleting a DS #6855

Merged
merged 6 commits into from
May 25, 2022
Merged

Updated success message (curl and TP) for deleting a DS #6855

merged 6 commits into from
May 25, 2022

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented May 24, 2022 •
edited
Loading

Related: #4351

Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Portal

What is the best way to verify this PR?

Create a DS or region or server
Delete a DS (see updated message), region and server (have same message as before i.e. server/region was deleted. on TO and server/region deleted on TP.

Updated message for DS

curl -X DELETE -k -H "Accept: application/json" --cookie "mojolicious=<mojolicious cookie>" https://localhost:8443/api/4.0/deliveryservices/<ds id>

{"alerts":[{
       "text":"ds was deleted. Perform a CDN snapshot then queue updates on all servers in the cdn for the changes to take affect.",
       "level":"success"
}]

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. labels May 25, 2022
@ocket8888
Copy link
Contributor

Should this new message maybe go in an info-level alert instead of appending it to the success message?

ocket8888
ocket8888 approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TP tests pending

@ocket8888 ocket8888 merged commit 7e6af10 into apache:master May 25, 2022
@rimashah25 rimashah25 deleted the feature/delete-ds-message branch May 25, 2022 18:20
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 2, 2022
@rimashah25
Updated success message (curl and TP) for deleting a DS (apache#6855)
18b1b81 
* Updated success message (curl and TP) for deleting a DS

* Updated CHANGELOG.md

* Updated DS integration test's validation message

* updated message to info level on TP and TO

* grammar check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocket8888 ocket8888 ocket8888 approved these changes

@mitchell852 mitchell852 mitchell852 left review comments

Assignees
No one assigned
Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rimashah25 @ocket8888 @mitchell852