Adding status and lastPoll fields to CrStates #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
reviewed
Mar 3, 2022
There was a problem hiding this comment.
Would you want to take this opportunity to fill out our missing docs for /publish/CrStates?
rawlinp
requested changes
Mar 3, 2022
docs/source/development/traffic_monitor/traffic_monitor_api.rst
Outdated
Show resolved
Hide resolved
docs/source/development/traffic_monitor/traffic_monitor_api.rst
Outdated
Show resolved
Hide resolved
rawlinp
requested changes
Mar 10, 2022
rawlinp
approved these changes
Mar 14, 2022
4 tasks
3 tasks
jrushford
added a commit
to jrushford/trafficcontrol
that referenced
this pull request
Mar 21, 2022
When the tc-health-client was switched to using the combined TM CrStates endpoint, the ability to log the cache status was lost, Issue apache#6448. PR apache#6612 adds the cache status field to the TM CrStates endpoint allowing cache status to be logged again. This PR adds back the cache status logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #6448
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TM locally and
GETthepublish/CrStatesendpoint. Make sure thestatusandlastPollfields show up in the output. Also confirm that the status for the caches is in fact what's being reported by theapi/cache-statusesendpoint.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist