Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow spaces in server interface router port name #6260

Merged

Conversation

ocket8888
Copy link
Contributor

Fixes #6259


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Start Traffic Portal, make sure you can create a server with a space in its router port name for one or more server interfaces

If this is a bugfix, which Traffic Control versions contained the bug?

  • master
  • 6.0.0 RC4

PR submission checklist

  • This PR does not have tests
  • This PR does not have documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 regression bug a bug in existing functionality introduced by a new version labels Oct 7, 2021
@ocket8888 ocket8888 self-assigned this Oct 7, 2021
@mitchell852 mitchell852 added this to the 6.0.1 milestone Oct 7, 2021
Copy link
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Manually tested and made sure that I could pass in port names with spaces.

@ocket8888 ocket8888 force-pushed the tp/fix-router-portname-restriction branch from b5717cc to 21afcc5 Compare October 7, 2021 21:45
@mattjackson220 mattjackson220 merged commit 21ae341 into apache:master Oct 7, 2021
@ocket8888 ocket8888 deleted the tp/fix-router-portname-restriction branch October 8, 2021 13:58
zrhoffman pushed a commit that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic Portal No Longer Allows Spaces in Server Object "Router Port Name"
4 participants