Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.x Backport: Add ORT/atstccfg Deterministic Config Generation (#4557) #5040

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Sep 17, 2020

  • Make ORT gen deterministic

  • Add ORT/atstccfg Line-Comment header

Adds a header to the multipart file, with the line comment syntax of
the file (if it has one).

This lets ORT safely strip line comments with times for diffing.

  • Remove ORT/atstccfg unnecessary io param

Removes TCCfg from GetAllConfigs, making the function Pure, which
makes it possible/easier to unit test.

  • Change ORT/atstccfg magic string to const

  • Add ORT/atstccfg unit test for determinism

(cherry picked from commit d74de45)

What does this PR (Pull Request) do?

  • This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Documentation
  • Grove
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • CI tests

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

* Make ORT gen deterministic

* Add ORT/atstccfg Line-Comment header

Adds a header to the multipart file, with the line comment syntax of
the file (if it has one).

This lets ORT safely strip line comments with times for diffing.

* Remove ORT/atstccfg unnecessary io param

Removes TCCfg from GetAllConfigs, making the function Pure, which
makes it possible/easier to unit test.

* Change ORT/atstccfg magic string to const

* Add ORT/atstccfg unit test for determinism

(cherry picked from commit d74de45)
@rob05c rob05c added the backport an upstream change merged into an older release label Sep 17, 2020
@rawlinp rawlinp merged commit a41e0b3 into apache:4.1.x Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport an upstream change merged into an older release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants