Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an HTTP-Header equivalent for 'format' TR Query Param #3554

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added an HTTP-Header equivalent for 'format' TR Query Param #3554

wants to merge 6 commits into from

Conversation

ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented May 7, 2019 •
edited
Loading

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Adds the X-TC-Format HTTP Header as an alternative to/equivalent of the format query parameter for TR to use in formatting responses to requests to STEERING Delivery Services.

Accepts either json (for compatibility with the query parameter) or application/json (for compatibility with HTTP content negotiation) to format response as JSON.

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Router

What is the best way to verify this PR?

You could run the TR unit tests, as well as verifying that TR responses to STEERING requests are properly formatted when X-TC-Format is given and set to a valid value.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@asfgit
Copy link
Contributor

asfgit commented May 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3629/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented May 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3634/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented May 14, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3665/
Test FAILed.

@ocket8888 ocket8888 marked this pull request as ready for review May 14, 2019 17:36
@asfgit
Copy link
Contributor

asfgit commented May 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3669/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Oct 15, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4507/

@ocket8888 ocket8888 added configuration related to configuration - not limited to any one component Traffic Router related to Traffic Router new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one and removed configuration related to configuration - not limited to any one component labels Oct 24, 2019
@asf-ci
Copy link
Contributor

asf-ci commented Nov 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4749/

@mitchell852 mitchell852 requested a review from rawlinp November 14, 2019 19:48
@ocket8888 ocket8888 force-pushed the format-header branch 2 times, most recently from 0660787 to 89982cf Compare October 30, 2020 15:54
@ocket8888 ocket8888 mentioned this pull request Jun 29, 2021
Closed
@ocket8888 ocket8888 force-pushed the format-header branch 2 times, most recently from 16553cc to 61e63bc Compare September 16, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlinp rawlinp Awaiting requested review from rawlinp

Assignees
No one assigned
Labels
low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Router related to Traffic Router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocket8888 @asfgit @asf-ci