Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOSED - Source the X509_CA_ENV_FILE in trafficops #3523

Closed
wants to merge 1 commit into from
Closed

CLOSED - Source the X509_CA_ENV_FILE in trafficops #3523

wants to merge 1 commit into from

Conversation

moltzaum
Copy link
Contributor

What does this PR (Pull Request) do?

When I start up my TO container with trafficvault, the ssl keys aren't added correctly because the environment variables aren't sourced. Every other run file sources the env variables correctly, so I'm using them as a reference.

Which Traffic Control components are affected by this PR?

  • CDN in a Box

What is the best way to verify this PR?

rm -rf trafficops/ca
Make sure volumes are removed by checking docker volume ls
docker-compose build trafficops
variables.env:96: AUTO_SNAPQUEUE_ENABLED=false
docker-compose up -d trafficops trafficvault
docker-compose logs -f trafficops

The trafficops logs should output exec tail -f /dev/null and stop. If the logs loop forever it didn't start up correctly.
I am running a limited stack, but running the whole stack should also work the same.

If this is a bug fix, what versions of Traffic Ops are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
    • I am doing what the other run files are doing, which should be sufficient. There isn't a "test" per-se, but there is a conditional to test if the env var was set.
  • Documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@asfgit
Copy link
Contributor

asfgit commented Apr 25, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3584/
Test FAILed.

@asfgit
Copy link
Contributor

asfgit commented Apr 25, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3585/
Test FAILed.

@mitchell852 mitchell852 added the cdn-in-a-box related to the Docker-based CDN-in-a-Box system label Apr 25, 2019
@moltzaum
Copy link
Contributor Author

retest this please

@asfgit
Copy link
Contributor

asfgit commented Apr 25, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3588/
Test PASSed.

@moltzaum
Copy link
Contributor Author

Closing because this PR solves the same issue: #3508

@moltzaum moltzaum closed this Apr 26, 2019
@moltzaum moltzaum deleted the ciab-to-env branch May 14, 2019 22:12
@mitchell852 mitchell852 changed the title Source the X509_CA_ENV_FILE in trafficops CLOSED - Source the X509_CA_ENV_FILE in trafficops Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned cdn-in-a-box related to the Docker-based CDN-in-a-Box system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants