Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP upgrades angularjs to 1.7.8 #3485

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Apr 12, 2019

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

This PR upgrades TP from angularjs 1.6.4 to 1.7.8 (the current stable release).

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Run the UI tests - https://github.com/apache/trafficcontrol/tree/master/traffic_portal/test/end_to_end

No new tests needed as this is a dependency upgrade but ensure the existing tests are not affected. There is no documentation changes required as we never documented which minor version of angularjs TP runs on.

If this is a bug fix, what versions of Traffic Ops are affected?

N/A

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added the Traffic Portal v1 related to Traffic Portal version 1 label Apr 12, 2019
@asfgit
Copy link
Contributor

asfgit commented Apr 12, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3516/
Test PASSed.

@ocket8888
Copy link
Contributor

Fails to build Traffic Portal:

bower                               ECONFLICT Unable to find suitable version for angular

@dangogh
Copy link
Member

dangogh commented Apr 19, 2019

builds fine for me...

@ocket8888
Copy link
Contributor

🤷‍♂️ I tried cleaning docker with docker system prune -af and rebuilt all of everything from scratch. Same deal

@mitchell852 mitchell852 added the improvement The functionality exists but it could be improved in some way. label Apr 24, 2019
@dangogh dangogh self-assigned this Apr 24, 2019
@dangogh dangogh merged commit 488039c into apache:master Apr 24, 2019
@mitchell852 mitchell852 deleted the tp-angular-1-7 branch July 15, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants