Fix deep_caching_type validator regex #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangogh
reviewed
Jan 26, 2018
| @@ -1387,7 +1387,7 @@ sub is_deliveryservice_valid { | |||
| active => [ is_required("is required") ], | |||
| cdnId => [ is_required("is required"), \&is_valid_int_or_undef ], | |||
| ccrDnsTtl => [ \&is_valid_int_or_undef ], | |||
| deepCachingType => [ is_like( qr/^NEVER|ALWAYS$/, "must be NEVER or ALWAYS" ) ], | |||
| deepCachingType => [ is_like( qr/^(NEVER|ALWAYS)$/, "must be NEVER or ALWAYS" ) ], | |||
There was a problem hiding this comment.
really minor nit.. looks like current code is using TABs to align the arrows.. can you match?
There was a problem hiding this comment.
Done, but if it were up to me everything would be using spaces :)
The regex is missing parentheses which allows any string starting with NEVER or ending with ALWAYS to be considered valid, but it would be disallowed at the DB level because it's an enum type.
0fc210d to
d4a1920
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex is missing parentheses which allows any string starting with
NEVER or ending with ALWAYS to be considered valid, but it would be
disallowed at the DB level because it's an enum type.
Thanks, @dangogh, for finding this!