Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TXT Records support #1720

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Adding TXT Records support #1720

merged 2 commits into from
Feb 12, 2018

Conversation

smalenfant
Copy link
Contributor

This adds TXT Record support to Traffic Router. To enable, you must also add a TXT Type in Traffic Ops and add your static record under your delivery service.

Added the feature so it could be used with Let's Encrypt (TBD).

@smalenfant smalenfant added new feature A new feature, capability or behavior Traffic Router related to Traffic Router labels Jan 2, 2018
@smalenfant smalenfant requested a review from elsloo January 2, 2018 20:42
@smalenfant
Copy link
Contributor Author

Didn't put the DB migration to include TXT in the standard types. I'd like some recommendations regarding that area.

@asfgit
Copy link
Contributor

asfgit commented Jan 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/839/
Test PASSed.

@rob05c rob05c added this to the 2.2.0 milestone Jan 25, 2018
@smalenfant
Copy link
Contributor Author

@elsloo Just added the seeds for that type of record as well.
@rob05c I believe this should be good to go, but double check with Jeff. This is really for Let's Encrypt support. They are coming this month with wildcard certificates which requires DNS challenge.

@asfgit
Copy link
Contributor

asfgit commented Jan 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/931/
Test PASSed.

@elsloo elsloo merged commit 5516554 into apache:master Feb 12, 2018
@rivasj
Copy link
Contributor

rivasj commented Feb 13, 2018

@smalenfant this PR has compilation failures, and when corrected, unit test failures. Please revisit

elsloo added a commit to elsloo/trafficcontrol that referenced this pull request Feb 13, 2018
@elsloo
This resolves the syntax and test issues that arose when PR apache#1720…
16f40da 
… was merged into master.
@elsloo elsloo mentioned this pull request Feb 13, 2018
Merged
dneuman64 pushed a commit that referenced this pull request Feb 13, 2018
@elsloo @dneuman64
This resolves the syntax and test issues that arose when PR #1720 was…
171042f 
… merged into master.
elsloo added a commit to elsloo/trafficcontrol that referenced this pull request Feb 14, 2018
@elsloo
This resolves the syntax and test issues that arose when PR apache#1720…
170dceb 
… was merged into master.

(cherry picked from commit 171042f)
@elsloo elsloo mentioned this pull request Feb 14, 2018
Merged
rob05c pushed a commit that referenced this pull request Feb 14, 2018
@elsloo @rob05c
This resolves the syntax and test issues that arose when PR #1720 was…
127c493 
… merged into master.

(cherry picked from commit 171042f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsloo elsloo Awaiting requested review from elsloo

Assignees

@elsloo elsloo

Labels
new feature A new feature, capability or behavior Traffic Router related to Traffic Router
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@smalenfant @asfgit @rivasj @elsloo @rob05c