Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops: Add Multiple custom access logs and Header field for ATS #1599

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

weifensh
Copy link
Contributor

@weifensh weifensh commented Nov 29, 2017

Currently TO supports only one custom access log file by configuring the "LogFormat" and "LogObject" parameters for "logs_xml.config". We have a requirement to support multiple custom access log files. As ATS does support this, we are planning to extend "LogFormat"&"LogObject" on TO, and add extra 9 groups (9 should be enough) of parameters like: "LogFormat1"&"LogObject1", "LogFormat2"&"LogObject2" ... "LogFormat9"&"LogObject9". Only when "LogFormatN"&"LogObjectN" are configured, they will appear in "logs_xml.config"; otherwise the file does not change, so the current behavior does not change either.

@asfgit
Copy link
Contributor

asfgit commented Nov 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/700/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Nov 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/659/

@weifensh
Copy link
Contributor Author

The UT failure above seems to be caused by the following line of existing code in ApacheTrafficServer.pm:
$self->app->log->error("Parameter package.trafficserver missing for profile ".$server->profile->name . ". Assuming version $ats_ver");

@smalenfant smalenfant self-assigned this Nov 29, 2017
@smalenfant smalenfant added the new feature A new feature, capability or behavior label Nov 29, 2017
@smalenfant smalenfant added this to the 2.2.0 milestone Nov 29, 2017
@smalenfant smalenfant added Traffic Ops related to Traffic Ops Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script labels Nov 29, 2017
@smalenfant smalenfant merged commit eb99d3d into apache:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature, capability or behavior Traffic Ops ORT *DEPRECATED* related to the traffic_ops_ort.pl script Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants