Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cdn query parameter filter to GET /deliveryserviceserver route #6034

Closed
rawlinp opened this issue Jul 15, 2021 · 0 comments · Fixed by #6186
Closed

Add support for cdn query parameter filter to GET /deliveryserviceserver route #6034

rawlinp opened this issue Jul 15, 2021 · 0 comments · Fixed by #6186
Assignees
@rawlinp
Labels
cache-config Cache config generation improvement The functionality exists but it could be improved in some way. performance impacts/improves/measures performance Traffic Ops related to Traffic Ops

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Jul 15, 2021

I'm submitting a ...

  • improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Traffic Ops
  • Traffic Ops ORT

Current behavior:

The GET /deliveryserviceserver route does not support filtering by CDN.

New behavior:

The GET /deliveryserviceserver route should have support for a ?cdn=my-cdn-name query parameter to filter the response by CDN. Once added, we should make t3c use it to filter by CDN instead of requesting the entirety of ds-server assignments across all CDNs. t3c has no need for ds-server assignments for CDNs outside of its own CDN, so this leads to unnecessary network bandwidth usage and database load.

Minimal reproduction of the problem with instructions:

GET /deliveryserviceserver?cdn=my-cdn, notice how it doesn't filter by the given CDN name.
@rawlinp rawlinp added Traffic Ops related to Traffic Ops performance impacts/improves/measures performance cache-config Cache config generation improvement The functionality exists but it could be improved in some way. labels Jul 15, 2021
@rawlinp rawlinp self-assigned this Sep 1, 2021
@rawlinp rawlinp mentioned this issue Sep 7, 2021
Merged
4 tasks
rawlinp added a commit to rawlinp/trafficcontrol that referenced this issue Sep 9, 2021
@rawlinp
Make t3c request less unnecessary DSS and jobs data
42ce708 
Use the new query parameters supported by Traffic Ops to reduce the
amount of unnecessary data requested from the /deliveryserviceserver and
/jobs APIs.

Closes: apache#5674
Closes: apache#6034
@rawlinp rawlinp mentioned this issue Sep 9, 2021
Merged
4 tasks
ocket8888 pushed a commit that referenced this issue Sep 10, 2021
@rawlinp
Make t3c request less unnecessary DSS and jobs data (#6186)
fe27e7e 
Use the new query parameters supported by Traffic Ops to reduce the
amount of unnecessary data requested from the /deliveryserviceserver and
/jobs APIs.

Closes: #5674
Closes: #6034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawlinp rawlinp

Labels
cache-config Cache config generation improvement The functionality exists but it could be improved in some way. performance impacts/improves/measures performance Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make t3c request less unnecessary DSS and jobs data rawlinp/trafficcontrol
1 participant
@rawlinp