Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic OPS ZIPCode #1761

Closed
RSK14 opened this issue Jan 12, 2018 · 6 comments · Fixed by #1792
Closed

Traffic OPS ZIPCode #1761

RSK14 opened this issue Jan 12, 2018 · 6 comments · Fixed by #1792
Assignees
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Milestone

Comments

@RSK14
Copy link

RSK14 commented Jan 12, 2018

Dear All,

I add to physical location unable to add 6 digital zip codes how to fix this issue. How to slow the issue?
only we can add 5digital zipcode.

Thanks,
Satheesh R

@dneuman64
Copy link
Contributor

Thanks for the issue! Unfortunately we made a bad assumption that zip codes are 5 digits because that is what they are in the US. While we work on a fix can you add just the first 5 digits of your zip code?

@dneuman64 dneuman64 added Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 Traffic Ops API bug something isn't working as intended labels Jan 12, 2018
@dneuman64 dneuman64 added this to the 2.2.0 milestone Jan 12, 2018
@dneuman64 dneuman64 self-assigned this Jan 12, 2018
@RSK14
Copy link
Author

RSK14 commented Jan 12, 2018 via email

@mitchell852
Copy link
Member

according to the database, the columns in the phys_location table really have no length limit so if it were me, I'd just remove all the maxlengths from to fix the Traffic Portal

https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js#L32

@RSK14 RSK14 closed this as completed Jan 18, 2018
@RSK14 RSK14 reopened this Jan 18, 2018
@RSK14
Copy link
Author

RSK14 commented Jan 18, 2018

Okay thanks, where i need to change this configuration.

@dneuman64
Copy link
Contributor

It's a simple code change. If you want, I can make the change and get a Pull Request in. If you prefer to make the change, I can show you where it needs to be done.

@RSK14
Copy link
Author

RSK14 commented Jan 22, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants