fix cannot read property 'forEach' of null charts (#7847)

apache · Nov 1, 2023 · 5d4db51 · 5d4db51
1 parent 747a3cd
commit 5d4db51
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js b/traffic_portal/app/src/common/modules/chart/bps/ChartBPSController.js
@@ -79,7 +79,7 @@ var ChartBPSController = function(deliveryService, $scope, $timeout, $filter, $q
 		var normalizedChartData = [];
 
 		if (angular.isDefined(series)) {
-			series.values.forEach(function(seriesItem) {
+			series.values?.forEach(function(seriesItem) {
 				if (moment(seriesItem[0]).isSame(start) || moment(seriesItem[0]).isAfter(start)) {
 					normalizedChartData.push([ moment(seriesItem[0]).valueOf(),
 						numberUtils.convertTo(seriesItem[1], $scope.unitSize) ]); // converts data to appropriate unit

diff --git a/traffic_portal/app/src/common/modules/chart/httpStatus/ChartHttpStatusController.js b/traffic_portal/app/src/common/modules/chart/httpStatus/ChartHttpStatusController.js
@@ -92,7 +92,7 @@ var ChartHttpStatusController = function(deliveryService, $scope, $timeout, $fil
 			series = result.series;
 
 		if (angular.isDefined(series)) {
-			series.values.forEach(function(seriesItem) {
+			series.values?.forEach(function(seriesItem) {
 				if (moment(seriesItem[0]).isSame(start) || moment(seriesItem[0]).isAfter(start)) {
 					if (_.isNumber(seriesItem[1])) {
 						normalizedChartData.push([ moment(seriesItem[0]).valueOf(), seriesItem[1] ]);

diff --git a/traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js b/traffic_portal/app/src/common/modules/chart/tps/ChartTPSController.js
@@ -78,7 +78,7 @@ var ChartTPSController = function(deliveryService, $scope, $timeout, $filter, $q
 		var normalizedChartData = [];
 
 		if (angular.isDefined(series)) {
-			series.values.forEach(function(seriesItem) {
+			series.values?.forEach(function(seriesItem) {
 				if (moment(seriesItem[0]).isSame(start) || moment(seriesItem[0]).isAfter(start)) {
 					normalizedChartData.push([ moment(seriesItem[0]).valueOf(), seriesItem[1] ]);
 				}