Update supported go versions #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of go 1.24.0, go 1.22.x is no longer supported. Update supported go versions to go 1.23 and go 1.24.
|
The biggest new feature of go 1.23 was the range-over-func iterators, but looking at https://pkg.go.dev/github.com/apache/thrift/lib/go/thrift I don't think any of our API can take advantage of that, so we likely don't need to make any other change in addition to this one. @dcelasun please let me know if you can think of anything we can improve with new features from 1.23 :) |
dcelasun
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
@dcelasun please let me know if you can think of anything we can improve with new features from 1.23 :)
I did a quick skim of the release notes. We might be able to use some of the slices/maps functions in a few places, but it would mostly be cosmetic, so let's go ahead as is :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of go 1.24.0, go 1.22.x is no longer supported. Update supported go versions to go 1.23 and go 1.24.