THRIFT-5833: Add ProcessorError #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86f2045 to
eb48ad8
Compare
dcelasun
approved these changes
Nov 15, 2024
lib/go/thrift/processor_factory.go
Outdated
| // TProcessorError is the combined original error returned by the endpoint | ||
| // implementation, and I/O error when writing the response back to the client. | ||
| // | ||
| // This type will be returned by Process function if there's an error happend |
There was a problem hiding this comment.
Suggested change
| // This type will be returned by Process function if there's an error happend | |
| // This type will be returned by Process function if there's an error happened |
eb48ad8 to
f29a1e4
Compare
Client: go Provide ProcessorError as the combined error of write i/o error and original error returned by the endpoint implementation, and update compiler to use that in Process functions.
f29a1e4 to
01c134d
Compare
|
@dcelasun I renamed it from |
dcelasun
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: go
Provide ProcessorError as the combined error of write i/o error and original error returned by the endpoint implementation, and update compiler to use that in Process functions.
[skip ci]anywhere in the commit message to free up build resources.