Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upload/download-artifacts from v3 to v4 #2915

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Bump upload/download-artifacts from v3 to v4 #2915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
# only upload while building ubuntu-20.04
- name: Archive built thrift compiler
if: matrix.os == 'ubuntu-20.04'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp/thrift
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-go/with-go/')

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
Expand All @@ -128,7 +128,7 @@ jobs:

- name: Upload go precross artifacts
if: matrix.go == '1.21'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: go-precross
if-no-files-found: error
Expand Down Expand Up @@ -182,7 +182,7 @@ jobs:
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-java/with-java/' | sed 's/without-kotlin/with-kotlin/')

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
Expand All @@ -200,7 +200,7 @@ jobs:
run: make -C lib/java install

- name: Upload java libthrift artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: libthrift
if-no-files-found: error
Expand All @@ -213,7 +213,7 @@ jobs:
run: make -C lib/java precross

- name: Upload java precross artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: java-precross
if-no-files-found: error
Expand All @@ -235,7 +235,7 @@ jobs:
run: make -C lib/kotlin precross

- name: Upload kotlin precross artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: kotlin-precross
if-no-files-found: error
Expand All @@ -257,7 +257,7 @@ jobs:
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-swift/with-swift/')

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
Expand All @@ -271,7 +271,7 @@ jobs:
run: make -C test/swift precross

- name: Upload swift precross artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: swift-precross
if-no-files-found: error
Expand Down Expand Up @@ -310,7 +310,7 @@ jobs:
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-rs/with-rs/')

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
Expand All @@ -333,7 +333,7 @@ jobs:
run: make -C test/rs precross

- name: Upload rust precross artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: rs-precross
if-no-files-found: error
Expand Down Expand Up @@ -381,7 +381,7 @@ jobs:
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-py3/with-py3/')

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
Expand Down Expand Up @@ -437,31 +437,31 @@ jobs:
sudo apt-get install -y --no-install-recommends openssl ca-certificates

- name: Download java precross artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: java-precross
path: lib/java/build

- name: Download kotlin precross artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: kotlin-precross
path: lib/kotlin

- name: Download swift precross artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: swift-precross
path: test/swift/CrossTests/.build/x86_64-unknown-linux-gnu/debug

- name: Download rust precross artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: rs-precross
path: test/rs/bin

- name: Download go precross artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: go-precross
path: test/go/bin
Expand All @@ -487,7 +487,7 @@ jobs:
--client ${{ matrix.client_lang }}

- name: Upload log files from failed cross test runs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cross-test-log
Expand Down
Loading