THRIFT-5745: Implement slog.LogValuer on go TStructs #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8254915 to
0b7f2d6
Compare
784df0a to
5d45e1e
Compare
fishy
added a commit
to reddit/baseplate.go
that referenced
this pull request
Jan 24, 2024
The next thrift release, 0.20.0, will add slog.LogValuer for all thrift generated errors [1] [2]. This prepares us so that WrapBaseplateError will keep the implementation if it's available to be used with slog. This also drops support to go 1.20. 1.22 is already at rc2 today so I think it's time to do that. [1]: apache/thrift#2884 [2]: https://issues.apache.org/jira/browse/THRIFT-5745
fishy
added a commit
to reddit/baseplate.go
that referenced
this pull request
Feb 6, 2024
The next thrift release, 0.20.0, will add slog.LogValuer for all thrift generated errors [1] [2]. This prepares us so that WrapBaseplateError will keep the implementation if it's available to be used with slog. This also drops support to go 1.20. 1.22 is already at rc2 today so I think it's time to do that. [1]: apache/thrift#2884 [2]: https://issues.apache.org/jira/browse/THRIFT-5745
Client: go Implement slog.LogValuer for all TStruct and TException generated by the compiler for go code. Also add SlogTStructWrapper in the library so we don't have to repeat it in the compiler generated go code.
fishy
added a commit
to reddit/baseplate.go
that referenced
this pull request
Feb 7, 2024
The next thrift release, 0.20.0, will add slog.LogValuer for all thrift generated errors [1] [2]. This prepares us so that WrapBaseplateError will keep the implementation if it's available to be used with slog. This also drops support to go 1.20. 1.22 is already at rc2 today so I think it's time to do that. [1]: apache/thrift#2884 [2]: https://issues.apache.org/jira/browse/THRIFT-5745
fishy
added a commit
to reddit/baseplate.go
that referenced
this pull request
Feb 7, 2024
The next thrift release, 0.20.0, will add slog.LogValuer for all thrift generated errors [1] [2]. This prepares us so that WrapBaseplateError will keep the implementation if it's available to be used with slog. This also drops support to go 1.20. 1.22 is already at rc2 today so I think it's time to do that. [1]: apache/thrift#2884 [2]: https://issues.apache.org/jira/browse/THRIFT-5745
fishy
added a commit
to reddit/baseplate.go
that referenced
this pull request
Feb 7, 2024
The next thrift release, 0.20.0, will add slog.LogValuer for all thrift generated errors [1] [2]. This prepares us so that WrapBaseplateError will keep the implementation if it's available to be used with slog. [1]: apache/thrift#2884 [2]: https://issues.apache.org/jira/browse/THRIFT-5745
fishy
added a commit
to reddit/baseplate.go
that referenced
this pull request
Feb 7, 2024
The next thrift release, 0.20.0, will add slog.LogValuer for all thrift generated errors [1] [2]. This prepares us so that WrapBaseplateError will keep the implementation if it's available to be used with slog. [1]: apache/thrift#2884 [2]: https://issues.apache.org/jira/browse/THRIFT-5745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: go
Implement slog.LogValuer for all TStruct and TException generated by the compiler for go code. Also add SlogTStructWrapper in the library so we don't have to repeat it in the compiler generated go code.