[THRIFT-5752] Add TTransportFactoryInterface

apache · Jan 6, 2024 · 53f9bad · 53f9bad
1 parent 8ea1a48
commit 53f9bad
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 8 deletions.
diff --git a/lib/php/Makefile.am b/lib/php/Makefile.am
@@ -64,7 +64,9 @@ phpfactory_DATA = \
 	lib/Factory/TJSONProtocolFactory.php \
 	lib/Factory/TProtocolFactory.php \
 	lib/Factory/TStringFuncFactory.php \
+	lib/Factory/TTransportFactoryInterface.php
 	lib/Factory/TTransportFactory.php
+	lib/Factory/TFramedTransportFactory.php
 
 phpprotocoldir = $(phpdir)/Protocol
 phpprotocol_DATA = \

diff --git a/lib/php/lib/Factory/TFramedTransportFactory.php b/lib/php/lib/Factory/TFramedTransportFactory.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace Thrift\Factory;
+
+use Thrift\Transport\TFramedTransport;
+use Thrift\Transport\TTransport;
+
+class TFramedTransportFactory implements TTransportFactoryInterface
+{
+    public static function getTransport(TTransport $transport)
+    {
+        return new TFramedTransport($transport);
+    }
+}
diff --git a/lib/php/lib/Factory/TTransportFactory.php b/lib/php/lib/Factory/TTransportFactory.php
@@ -4,7 +4,7 @@
 
 use Thrift\Transport\TTransport;
 
-class TTransportFactory
+class TTransportFactory implements TTransportFactoryInterface
 {
     /**
      * @static

diff --git a/lib/php/lib/Factory/TTransportFactoryInterface.php b/lib/php/lib/Factory/TTransportFactoryInterface.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Thrift\Factory;
+
+use Thrift\Transport\TTransport;
+
+interface TTransportFactoryInterface
+{
+    /**
+     * @static
+     * @param TTransport $transport
+     * @return TTransport
+     */
+    public static function getTransport(TTransport $transport);
+}
diff --git a/lib/php/lib/Server/TServer.php b/lib/php/lib/Server/TServer.php
@@ -2,7 +2,7 @@
 
 namespace Thrift\Server;
 
-use Thrift\Factory\TTransportFactory;
+use Thrift\Factory\TTransportFactoryInterface;
 use Thrift\Factory\TProtocolFactory;
 
 /**
@@ -30,14 +30,14 @@ abstract class TServer
     /**
      * Input transport factory
      *
-     * @var TTransportFactory
+     * @var TTransportFactoryInterface
      */
     protected $inputTransportFactory_;
 
     /**
      * Output transport factory
      *
-     * @var TTransportFactory
+     * @var TTransportFactoryInterface
      */
     protected $outputTransportFactory_;
 
@@ -60,17 +60,17 @@ abstract class TServer
      *
      * @param object $processor
      * @param TServerTransport $transport
-     * @param TTransportFactory $inputTransportFactory
-     * @param TTransportFactory $outputTransportFactory
+     * @param TTransportFactoryInterface $inputTransportFactory
+     * @param TTransportFactoryInterface $outputTransportFactory
      * @param TProtocolFactory $inputProtocolFactory
      * @param TProtocolFactory $outputProtocolFactory
      * @return void
      */
     public function __construct(
         $processor,
         TServerTransport $transport,
-        TTransportFactory $inputTransportFactory,
-        TTransportFactory $outputTransportFactory,
+        TTransportFactoryInterface $inputTransportFactory,
+        TTransportFactoryInterface $outputTransportFactory,
         TProtocolFactory $inputProtocolFactory,
         TProtocolFactory $outputProtocolFactory
     ) {