fix(security): grant TableSchemaView to all default roles

[codenamelxl]

SUMMARY

Fix: #25451
TableSchemaView appears to only be used within SqlLab but the permission is Alpha only

This prevents users with sql_lab role only from:

• Loading table preview
• Close table schema on left pane
• Expan table schema on left pane

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset/security/manager.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (76d897e) to head (1eb5464).
Report is 1470 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #32340       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.96%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39098    -37138     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32630    -13484     
+ Misses      28017     6468    -21549     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.50% <ø> (-0.67%)	⬇️
javascript	?
mysql	75.85% <ø> (?)
postgres	75.92% <ø> (?)
presto	53.03% <ø> (-0.78%)	⬇️
python	83.45% <ø> (+19.96%)	⬆️
sqlite	75.43% <ø> (?)
unit	61.06% <ø> (+3.44%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

I see that you're removing it from Alpha, but I don't see it being added to other roles. Should it be? Just making sure the work matches the PR description :)