Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): Docker python-translation-build #32163

Merged

Conversation

EmmanuelCbd
Copy link
Contributor

@EmmanuelCbd EmmanuelCbd commented Feb 6, 2025

SUMMARY

This PR fix the Docker compiler python translation build.
The build didn't run, this step was just passed, because BUILD_TRANSLATIONS flag was not set into python-translation-compiler layer.

fixes: #32161

TESTING INSTRUCTIONS

Set BUILD_TRANSLATIONS to "true"
run docker build and check into folder superset/translations/xx/LC_MESSAGES
With this fix, .mo files are available.

ADDITIONAL INFORMATION

@mistercrunch mistercrunch changed the title fix(docker) Docker python-translation-build fix(docker): Docker python-translation-build Feb 6, 2025
@mistercrunch
Copy link
Member

There are some intricacies as to how ARG/ENV persist across FROM statements in Dockerfile. I think ENV does persist as long as you build upon the previous base, which is super confusing. We may want to audit the whole file and systematically repeat the ARG/ENV in each layer where they are used... It's not DRY, but may prevent issues/confusion...

@sadpandajoe sadpandajoe added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 6, 2025
@rusackas
Copy link
Member

rusackas commented Feb 6, 2025

@mistercrunch I almost clicked the merge button here, but held off — do you see that audit as a blocker for this?

@mistercrunch mistercrunch merged commit 5a8488a into apache:master Feb 6, 2025
52 of 55 checks passed
@mistercrunch
Copy link
Member

Not a blocker, merged!

michael-s-molina pushed a commit that referenced this pull request Feb 12, 2025
sfirke pushed a commit to sfirke/superset that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No python translations when running Docker python translation compiler - missing ENV parameter
4 participants