-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fe/dashboard-list): display modifier info for Last modified
data
#32035
base: master
Are you sure you want to change the base?
fix(fe/dashboard-list): display modifier info for Last modified
data
#32035
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Signed-off-by: hainenber <dotronghai96@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/src/pages/DashboardList/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Thanks for this fix! Did you see that in the issue, I identified what I think is an end-to-end test that failed to catch this regression? If my assessment is correct - I'm new to that part of the project - it would be ideal if this test got updated to avoid such a regression in the future. |
@sfirke the linked test is not an E2E one though, it's a component test. I'd like to add an E2E test to cover this regression but Cypress doesn't really support hovering so it's a real hassle atm. Once we migrated to Playwright, it'll be a breeze instead. Hope this helps! |
Got it @hainenber - thanks for explaining that and thanks for the fix! |
SUMMARY
fix(fe/dashboard-list): display modifier info for
Last modified
dataFix #31258
The tooltip showing modifier data on
Last modified
cell is now restored.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
Screen.Recording.2025-01-30.at.21.10.59.mov
After
Screen.Recording.2025-01-30.at.21.08.55.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION