chore: Upgrade to React 17 #31961
Draft
chore: Upgrade to React 17 #31961
+36,793
−79,527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use |
villebro
reviewed
Jan 22, 2025
| "react": "^15 || ^16" | ||
| "react": "^16 || ^17" |
There was a problem hiding this comment.
Here and elsewhere, could we just remove support for ^16? As we're doing breaking changes, let's not be shy with the sledgehammer! 😁
| @@ -23,7 +23,7 @@ import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only'; | |||
| import 'jest-enzyme'; | |||
| import jQuery from 'jquery'; | |||
| import { configure } from 'enzyme'; | |||
| import Adapter from 'enzyme-adapter-react-16'; | |||
| import Adapter from '@wojtekmaj/enzyme-adapter-react-17'; | |||
There was a problem hiding this comment.
I see this is an "unofficial" package - am I reading this correctly that Enzyme doesn't support React > 16 natively?
There was a problem hiding this comment.
Yep, that package is suggested as a substitute by chatgpt/stackoverflow. Hopefully though we can get rid of enzyme tests soon
| @@ -415,7 +415,7 @@ export default class CRUDCollection extends PureComponent< | |||
| )), | |||
| ); | |||
| if (allowAddItem) { | |||
| tds.push(<td key="add" />); | |||
| tds.push(<td key="add" aria-label="dd" />); | |||
There was a problem hiding this comment.
Was this supposed to be aria-label="Add"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION