chore: refactor upload data, less permissions and less endpoints #31958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request unifies csv, excel and columnar upload endpoints and permissions into a single endpoint and permission type.
This is a breaking change related with Apache Superset 5.0
Removes the following endpoints:
POST
/api/v1/database/csv_metadata
POST
/api/v1/database/excel_metadata
POST
/api/v1/database/columnar_metadata
POST
/api/v1/database/<id>/csv_upload
POST
/api/v1/database/<id>/excel_upload
POST
/api/v1/database/<id>/columnar_upload
And adds the following generic endpoints:
/api/v1/database/upload_metadata
/api/v1/database/<id>/upload
Removes the following permissions:
can csv upload on Database
can excel upload on Database
can columnar upload on Database
And adds the following permission:
can upload on Database
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION