Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more clickhouse disallowed functions on config #31198

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

dpgaspar
Copy link
Member

SUMMARY

Adding more Clickhouse functions to our disallowed config. Although these functions could and possibly should not be authorized by the database credentials set by an Superset admin, it's a plus for Superset to disallow them by default.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (76d897e) to head (a91d7e3).
Report is 1118 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31198       +/-   ##
===========================================
+ Coverage   60.48%   83.81%   +23.32%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38932    -37304     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32631    -13483     
+ Misses      28017     6301    -21716     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.79% <ø> (-0.38%) ⬇️
javascript ?
mysql 76.55% <ø> (?)
postgres 76.64% <ø> (?)
presto 53.29% <ø> (-0.52%) ⬇️
python 83.81% <ø> (+20.32%) ⬆️
sqlite 76.10% <ø> (?)
unit 60.87% <ø> (+3.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina
Copy link
Member

Thanks for the PR @dpgaspar. Could you add something to UPDATING.md?

@dpgaspar
Copy link
Member Author

dpgaspar commented Dec 2, 2024

Thanks for the PR @dpgaspar. Could you add something to UPDATING.md?

ok added

@dpgaspar dpgaspar merged commit 25f4226 into apache:master Dec 3, 2024
37 checks passed
@dpgaspar dpgaspar deleted the chore/clickhous-allowed-functions branch December 3, 2024 10:48
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants