Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): prevent browser to download the entire video in first page load + fix empty controls attribute #28319

Merged
merged 1 commit into from
May 2, 2024
Merged

fix(docs): prevent browser to download the entire video in first page load + fix empty controls attribute #28319

merged 1 commit into from
May 2, 2024

Conversation

hainenber
Copy link
Contributor

fix(docs): prevent browser from downloading the entire overview video in the first page load
fix(docs): allow embedded video to be playable

SUMMARY

As above

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label May 2, 2024
rusackas
rusackas approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks!

@rusackas rusackas merged commit 593c653 into apache:master May 2, 2024
29 of 30 checks passed
@rusackas
Copy link
Member

rusackas commented May 2, 2024

I wonder if this would work on the README.md too.

@hainenber hainenber deleted the fix-video-overview-video-tag branch May 5, 2024 00:01
@hainenber hainenber mentioned this pull request May 5, 2024
Merged
9 tasks
dpgaspar pushed a commit to preset-io/superset that referenced this pull request May 6, 2024
@hainenber @dpgaspar
fix(docs): prevent browser to download the entire video in first page…
b2da4fd 
… load + fix empty `controls` attribute (apache#28319)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@hainenber @jzhao62
fix(docs): prevent browser to download the entire video in first page…
bee4537 
… load + fix empty `controls` attribute (apache#28319)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@hainenber
fix(docs): prevent browser to download the entire video in first page…
393ef6f 
… load + fix empty `controls` attribute (apache#28319)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @rusackas @mistercrunch