Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dynamic filter does not show all values on blur/clear events #28036

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: Dynamic filter does not show all values on blur/clear events #28036

merged 1 commit into from
Apr 16, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug where a filter was not showing all values on blur/clear events when the Dynamically search all filter values option is checked.

Fix #28004.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-04-15.at.08.55.11.mov
Screen.Recording.2024-04-15.at.09.44.58.mov

TESTING INSTRUCTIONS

Check the original issue and videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

rusackas
rusackas approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if tests are needed to harden it against regression, but the change looks clean.

@michael-s-molina michael-s-molina merged commit 6e01a68 into apache:master Apr 16, 2024
30 of 31 checks passed
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Apr 16, 2024
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Dynamic filter does not show all values on blur/clear events (#2…
36ba5c9 
…8036)

(cherry picked from commit 6e01a68)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Dynamic filter does not show all values on blur/clear events (#2…
ab950f8 
…8036)

(cherry picked from commit 6e01a68)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Dynamic filter does not show all values on blur/clear events (#2…
f8369d3 
…8036)

(cherry picked from commit 6e01a68)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Dynamic filter does not show all values on blur/clear events (#2…
ee92eeb 
…8036)

(cherry picked from commit 6e01a68)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@michael-s-molina @qleroy
fix: Dynamic filter does not show all values on blur/clear events (ap…
bed011b 
…ache#28036)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@michael-s-molina @jzhao62
fix: Dynamic filter does not show all values on blur/clear events (ap…
da7c92f 
…ache#28036)
@mistercrunch mistercrunch added 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 2, 2024
@dosubot dosubot bot mentioned this pull request Jul 8, 2024
Open
3 tasks
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: Dynamic filter does not show all values on blur/clear events (ap…
e38e1d8 
…ache#28036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@justinpark justinpark Awaiting requested review from justinpark

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After clearning selceted values on Dashboard filters deosn't show all value
3 participants
@michael-s-molina @rusackas @mistercrunch