Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select is accepting unknown pasted values when allowNewOptions is false #28017

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: Select is accepting unknown pasted values when allowNewOptions is false #28017

merged 1 commit into from
Apr 15, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fix a bug where the Select component was accepting unknown pasted values when allowNewOptions is false.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-04-12.at.16.17.00.mov
Screen.Recording.2024-04-12.at.16.16.17.mov

TESTING INSTRUCTIONS

1 - Set allowNewOptions to false
2 - Paste an unknown value
3 - The component should not accept the value

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

justinpark
justinpark approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This fix cleans up all issues.

@justinpark justinpark mentioned this pull request Apr 12, 2024
Closed
9 tasks
kgabryje
kgabryje approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit caad29b into apache:master Apr 15, 2024
30 of 31 checks passed
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Apr 15, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@michael-s-molina @EnxDev
fix: Select is accepting unknown pasted values when allowNewOptions…
bfb1036 
… is false (apache#28017)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Select is accepting unknown pasted values when allowNewOptions…
e8784c4 
… is false (#28017)

(cherry picked from commit caad29b)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Select is accepting unknown pasted values when allowNewOptions…
bf6cd56 
… is false (#28017)

(cherry picked from commit caad29b)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Select is accepting unknown pasted values when allowNewOptions…
b5a878a 
… is false (#28017)

(cherry picked from commit caad29b)
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Select is accepting unknown pasted values when allowNewOptions…
41230db 
… is false (#28017)

(cherry picked from commit caad29b)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@michael-s-molina @qleroy
fix: Select is accepting unknown pasted values when allowNewOptions…
fb43f14 
… is false (apache#28017)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@michael-s-molina @jzhao62
fix: Select is accepting unknown pasted values when allowNewOptions…
f50fa0f 
… is false (apache#28017)
@mistercrunch mistercrunch added 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 2, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: Select is accepting unknown pasted values when allowNewOptions…
1cd9a22 
… is false (apache#28017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@justinpark justinpark justinpark approved these changes

@geido geido Awaiting requested review from geido geido is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @justinpark @kgabryje @mistercrunch