Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): missed one bump from node 16 to 18. #27955

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(node): missed one bump from node 16 to 18. #27955

merged 1 commit into from
Apr 9, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 9, 2024

SUMMARY

I tried to bump everything to node 18 in this PR, but I seem to have missed one. Thanks for catching it, @mistercrunch :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

If CI (E2E specifically) passes, we're all good.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Apr 9, 2024
mistercrunch
mistercrunch approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit a5e65d5 into master Apr 9, 2024
29 of 30 checks passed
@rusackas rusackas deleted the missed-a-node-bump branch April 9, 2024 21:44
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@rusackas @EnxDev
fix(node): missed one bump from node 16 to 18. (apache#27955)
89c7680
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@rusackas @qleroy
fix(node): missed one bump from node 16 to 18. (apache#27955)
1651219
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@rusackas @jzhao62
fix(node): missed one bump from node 16 to 18. (apache#27955)
baeb2c6
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rusackas
fix(node): missed one bump from node 16 to 18. (apache#27955)
1268c43
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rusackas @mistercrunch