Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-table): Revert "fix(chart table in dashboard): improve screen reading of table (#26453)" #26963

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Feb 1, 2024

SUMMARY

PR #26453 introduced important accessibility upgrades, but broke displaying table totals in sticky mode. Since the totals being always visible (sticky) is a key feature of the table chart, I think we should revert the accessibility PR and reopen it once the bug is fixed.

CC @ncar285 @eschutho

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before the revert:

Screen.Recording.2024-02-01.at.11.51.07.mov

After:

Screen.Recording.2024-02-01.at.11.53.38.mov

TESTING INSTRUCTIONS

  1. Create a table chart with enough rows to enable scrolling
  2. Check "Show totals"
  3. Verify that totals row is sticky

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5ed8f67) 67.19% compared to head (92e058e) 67.18%.

Files Patch % Lines
...ugin-chart-table/src/DataTable/hooks/useSticky.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26963      +/-   ##
==========================================
- Coverage   67.19%   67.18%   -0.01%     
==========================================
  Files        1899     1899              
  Lines       74347    74347              
  Branches     8263     8263              
==========================================
- Hits        49954    49951       -3     
- Misses      22344    22347       +3     
  Partials     2049     2049              
Flag Coverage Δ
javascript 56.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit e4eae9a into apache:master Feb 1, 2024
36 checks passed
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 2, 2024
@sadpandajoe
Copy link
Member

🏷️ preset:2024.5

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants