-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Duplicated plugin registration #26379
Merged
michael-s-molina
merged 2 commits into
apache:master
from
michael-s-molina:fix-duplicated-plugin-registration
Dec 29, 2023
Merged
fix: Duplicated plugin registration #26379
michael-s-molina
merged 2 commits into
apache:master
from
michael-s-molina:fix-duplicated-plugin-registration
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26379 +/- ##
==========================================
- Coverage 69.18% 69.14% -0.04%
==========================================
Files 1946 1946
Lines 75988 75986 -2
Branches 8479 8479
==========================================
- Hits 52570 52541 -29
- Misses 21228 21266 +38
+ Partials 2190 2179 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
approved these changes
Dec 29, 2023
michael-s-molina
added
v3.0
Label added by the release manager to track PRs to be included in the 3.0 branch
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
labels
Jan 3, 2024
michael-s-molina
added a commit
that referenced
this pull request
Jan 3, 2024
(cherry picked from commit 29633e7)
michael-s-molina
added a commit
that referenced
this pull request
Jan 3, 2024
(cherry picked from commit 29633e7)
9 tasks
michael-s-molina
removed
the
v3.0
Label added by the release manager to track PRs to be included in the 3.0 branch
label
Jan 4, 2024
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit 29633e7)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Mar 8, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes the duplicated plugin registration that generates the following type of warning:
The duplicate registration was necessary when those pages belonged to different React apps. Now, they belong to the same app which makes the registration unnecessary.
The registration should happen only once when the application initializes.
TESTING INSTRUCTIONS
1 - Open any dashboard
2 - Check that the warnings are not there anymore
ADDITIONAL INFORMATION