-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clean up the examples dashboards #26158
chore: Clean up the examples dashboards #26158
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26158 +/- ##
===========================================
+ Coverage 58.93% 69.16% +10.23%
===========================================
Files 1941 1941
Lines 75873 75907 +34
Branches 8447 8457 +10
===========================================
+ Hits 44714 52504 +7790
+ Misses 28984 21207 -7777
- Partials 2175 2196 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@michael-s-molina thanks for the cleanup. I suspect we're removing filter box from dashboards and thus ideally we replace said filter boxes with native filters. |
We can do that as a follow-up. At the moment, the focus is on removing the inconsistencies and errors. |
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://35.92.148.196:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR! I'm happy to jam with you on adding filters, spiffing up the charts, etc. if there's ever a good day to do so.
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 3ab27c6)
(cherry picked from commit 3ab27c6)
SUMMARY
This PR cleans up the examples dashboards by adjusting the dashboards layouts and removing:
Fixes #26133
TESTING INSTRUCTIONS
1 - Make sure the command to load the examples runs successfully
2 - Make sure there's no filter box
3 - Make sure all charts render correctly
4 - Make sure there are no deleted charts
ADDITIONAL INFORMATION