Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup unused code in pandas 2.0+ #26013

Merged
merged 1 commit into from
Nov 19, 2023
Merged

chore: cleanup unused code in pandas 2.0+ #26013

merged 1 commit into from
Nov 19, 2023

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Nov 17, 2023 •
edited by john-bodley
Loading

SUMMARY

This is a follow-up of #24705 that bumped pandas. Per the Pandas 2.0 changelog the mangle_dupe_cols was removed as the functionality was never implemented. This PR cleans up the residues.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley self-requested a review November 17, 2023 17:51
@john-bodley
Copy link
Member

Thanks @gnought for the cleanup. Would you mind rebasing your PR? There's a flaky test which is failing which has been remedied in the master branch.

@gnought gnought force-pushed the chore/cleanup_pandas_2 branch from 5378d43 to ed8958e Compare November 18, 2023 09:03
@villebro
Copy link
Member

There's a flaky GAQ integration test that failed the mysql workflow. I restarted it, will check in soon to see if it passes

villebro
villebro approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 2499a1c into apache:master Nov 19, 2023
33 checks passed
@gnought gnought deleted the chore/cleanup_pandas_2 branch November 26, 2023 02:20
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@gnought @josedev-union
chore: cleanup unused code in pandas 2.0+ (apache#26013)
4c0a25d
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@gnought
chore: cleanup unused code in pandas 2.0+ (apache#26013)
c814b12
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@gnought @sfirke
chore: cleanup unused code in pandas 2.0+ (apache#26013)
ff86470
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@gnought
chore: cleanup unused code in pandas 2.0+ (apache#26013)
9123106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnought @john-bodley @villebro @mistercrunch