Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typo): replace 'datasouce_id' with 'datasource_id' in openapi.json #25875

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(typo): replace 'datasouce_id' with 'datasource_id' in openapi.json #25875

merged 1 commit into from
Nov 6, 2023

Conversation

nero5700
Copy link
Contributor

@nero5700 nero5700 commented Nov 6, 2023

SUMMARY

fix typo: replace 'datasouce_id' with 'datasource_id' in docs/static/resources/openapi.json

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

john-bodley
john-bodley approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nero5700 for fixing the spelling mistakes.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Nov 6, 2023
@rusackas rusackas merged commit 5e5a9c6 into apache:master Nov 6, 2023
29 checks passed
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Nov 30, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@nero5700
fix(typo): replace 'datasouce_id' with 'datasource_id' in openapi.json (
5d024a2 
apache#25875)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@nero5700 @sfirke
fix(typo): replace 'datasouce_id' with 'datasource_id' in openapi.json (
c8b0c60 
apache#25875)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@nero5700
fix(typo): replace 'datasouce_id' with 'datasource_id' in openapi.json (
9d1d9a8 
apache#25875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nero5700 @john-bodley @mistercrunch @rusackas