Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: define localhost for docker #25480

Merged
merged 3 commits into from
Oct 3, 2023
Merged

docs: define localhost for docker #25480

merged 3 commits into from
Oct 3, 2023

Conversation

mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented Oct 1, 2023 •
edited
Loading

SUMMARY

Address bugherd task 28

cc: @sfirke @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sfirke
Copy link
Member

sfirke commented Oct 2, 2023

For recordkeeping: Implements #22165

sfirke
sfirke approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Oct 2, 2023
@mdeshmu
Copy link
Contributor Author

mdeshmu commented Oct 2, 2023

@sfirke pre-commit failure is not related to this PR.

tests/unit_tests/db_engine_specs/test_clickhouse.py:66: error: Argument 1 to "NewConnectionError" has incompatible type "str"; expected "HTTPConnection" [arg-type]

@john-bodley
Copy link
Member

@mdeshmu would you mind providing links to the issues you mentioned to aid with context?

@sfirke
Copy link
Member

sfirke commented Oct 2, 2023

BugHerd issue is https://www.bugherd.com/projects/334204/tasks/28

@mdeshmu
Copy link
Contributor Author

mdeshmu commented Oct 3, 2023

This is ready to merge

@sfirke sfirke merged commit 7a88ad3 into apache:master Oct 3, 2023
@sfirke sfirke removed the merge-if-green If approved and tests are green, please go ahead and merge it for me label Oct 11, 2023
@mdeshmu mdeshmu deleted the bugherd-28 branch October 13, 2023 15:25
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mdeshmu @sfirke
docs: define localhost for docker (apache#25480)
d106969 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mdeshmu @sfirke
docs: define localhost for docker (apache#25480)
4f5993d 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfirke sfirke sfirke approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdeshmu @sfirke @john-bodley @mistercrunch