Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(misc): Typos in config.py #25465

Merged
merged 2 commits into from
Sep 30, 2023
Merged

chore(misc): Typos in config.py #25465

merged 2 commits into from
Sep 30, 2023

Conversation

JZ6
Copy link
Contributor

@JZ6 JZ6 commented Sep 29, 2023

SUMMARY

Fixed numerous typos in config.py documentation, thanks

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

sfirke
sfirke approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, thanks!

@sfirke sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Sep 29, 2023
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Sep 29, 2023
john-bodley
john-bodley approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JZ6 for the change.

@rusackas rusackas merged commit a14fcc9 into apache:master Sep 30, 2023
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 2, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@JZ6 @sfirke
chore(misc): Typos in config.py (apache#25465)
588ea03 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@JZ6 @sfirke
chore(misc): Typos in config.py (apache#25465)
b26a26c 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sfirke sfirke sfirke approved these changes

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JZ6 @john-bodley @sfirke @mistercrunch @rusackas