Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Explore tooltip copy #25438

Merged
merged 14 commits into from
Sep 30, 2023
Merged

chore: Update Explore tooltip copy #25438

merged 14 commits into from
Sep 30, 2023

Conversation

yousoph
Copy link
Member

@yousoph yousoph commented Sep 27, 2023

SUMMARY

Updating copy on some Explore tooltips to provide additional info / clarification

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before After
image image
image image
image image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #25438 (ac1f8c4) into master (f0080f9) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25438   +/-   ##
=======================================
  Coverage   69.08%   69.08%           
=======================================
  Files        1909     1909           
  Lines       74857    74857           
  Branches     8283     8283           
=======================================
  Hits        51716    51716           
  Misses      21002    21002           
  Partials     2139     2139           
Flag Coverage Δ
hive 53.74% <ø> (ø)
javascript 56.18% <ø> (ø)
mysql 78.41% <ø> (ø)
postgres 78.50% <ø> (ø)
presto 53.69% <ø> (ø)
python 82.92% <ø> (ø)
sqlite 77.14% <ø> (ø)
unit 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 58.33% <ø> (ø)
...rt-controls/src/shared-controls/sharedControls.tsx 55.93% <ø> (ø)
...n-chart-handlebars/src/plugin/controls/metrics.tsx 41.66% <ø> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 53.03% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yousoph
Copy link
Member Author

yousoph commented Sep 27, 2023

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.219.70.115:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member Author

yousoph commented Sep 29, 2023

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.217.179.190:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e36e0fd into master Sep 30, 2023
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the tooltip-copy-updates branch March 26, 2024 18:02
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants