Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): fast follow for Tags flatten api + update client with generator + some bug fixes #25309

Merged
merged 5 commits into from
Sep 18, 2023
Merged

feat(tag): fast follow for Tags flatten api + update client with generator + some bug fixes #25309

merged 5 commits into from
Sep 18, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Sep 14, 2023

SUMMARY

  • update client with new api call pattern
  • adding owners check before bulk tagging
  • fixing remove all from tag edit can not be saved

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title feat(tag): flatten api + update client with generator feat(tag): fast follow for Tags flatten api + update client with generator + some bug fixes Sep 14, 2023
@hughhhh hughhhh force-pushed the tags-ff-updates branch 2 times, most recently from 32fbfc7 to f49ba82 Compare September 14, 2023 20:51
betodealmeida
betodealmeida previously requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand this correctly, but I don't think we should allow Nones to be passed.

superset-frontend/src/features/tags/BulkTagModal.tsx Show resolved Hide resolved
superset/tags/schemas.py Outdated Show resolved Hide resolved
superset/tags/schemas.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 15, 2023
@yousoph
Copy link
Member

yousoph commented Sep 15, 2023

/testenv up FEATURE_TAGGING_SYSTEM=True

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://18.236.123.237:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Sep 15, 2023

/testenv up FEATURE_TAGGING_SYSTEM=True

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.222.109.187:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho dismissed betodealmeida’s stale review September 18, 2023 18:55

changes were addressed.

@eschutho
Copy link
Member

Looks like @hughhhh addressed @betodealmeida's concerns, so I'm going to merge this, but we can fast follow with other changes if needed.

@eschutho eschutho merged commit 090ae64 into apache:master Sep 18, 2023
@eschutho eschutho deleted the tags-ff-updates branch September 18, 2023 18:56
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Sep 18, 2023
@hughhhh @jinghua-qa
feat(tag): fast follow for Tags flatten api + update client with gene…
22777b9 
…rator + some bug fixes (apache#25309)

(cherry picked from commit 090ae64)
eschutho pushed a commit to Superset-Community-Partners/superset that referenced this pull request Sep 21, 2023
@hughhhh @eschutho
feat(tag): fast follow for Tags flatten api + update client with gene…
97fd522 
…rator + some bug fixes (apache#25309)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@hughhhh
feat(tag): fast follow for Tags flatten api + update client with gene…
563df46 
…rator + some bug fixes (apache#25309)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@hughhhh
feat(tag): fast follow for Tags flatten api + update client with gene…
aecdd0a 
…rator + some bug fixes (apache#25309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hughhhh @yousoph @eschutho @betodealmeida @mistercrunch