-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Support HPA for supersetNode and supersetWorker #25280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Looks like you're missing License info from the new HPA files, but otherwise LGTM.
We have added the licence info copied from one of the other templates to the 2 new files. Thanks. |
I think you're missing newlines at the end of those files as well |
Added. Thanks. |
…5280) Co-authored-by: Nav_InverseInfinity <naveen.damotharan@outlook.com>
…5280) Co-authored-by: Nav_InverseInfinity <naveen.damotharan@outlook.com>
Seems flask isn't reading the cache correctly when in HPA mode: HTTPException |
…5280) Co-authored-by: Nav_InverseInfinity <naveen.damotharan@outlook.com>
SUMMARY
Support auto-scaling the supersetNode and supersetWorker using HPA with CPU/MEM metrics.
When enabled in helm values, will create HPA objects and omit the static number of replicas from the deployments.
HPA templates have been derived from the standard templates generated using
helm create
.The default is disabled.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
HPA Objects are created after the values are configured and feature enabled:
HPA Is reacting to CPU load and increasing replicas:
Pods created
TESTING INSTRUCTIONS
Apply with custom values.yaml and set the following options :
The same options can be set for
supersetWorker
The helm install/upgrade will then create the HPA objects and starts monitoring the resource usage and scale replicas.
To simulate CPU load we added a sidecar which generates load as the HPA averages across all containers in the pods.
ADDITIONAL INFORMATION