-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): Migrate tests to typescript #25274
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import React from 'react'; | ||
|
||
import HighlightedSql from 'src/SqlLab/components/HighlightedSql'; | ||
import { fireEvent, render } from 'spec/helpers/testing-library'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you @justinpark for the improvements! We generally avoid There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can check our Testing Guidelines and Best Practices to improve even more the tests 😉 |
||
|
||
const sql = | ||
"SELECT * FROM test WHERE something='fkldasjfklajdslfkjadlskfjkldasjfkladsjfkdjsa'"; | ||
test('renders HighlightedSql component with sql prop', () => { | ||
expect(React.isValidElement(<HighlightedSql sql={sql} />)).toBe(true); | ||
}); | ||
test('renders a ModalTrigger component', () => { | ||
const { getByTestId } = render(<HighlightedSql sql={sql} />); | ||
expect(getByTestId('span-modal-trigger')).toBeInTheDocument(); | ||
}); | ||
test('renders a ModalTrigger component with shrink prop and maxWidth prop set to 20', () => { | ||
const { getByTestId } = render( | ||
<HighlightedSql sql={sql} shrink maxWidth={20} />, | ||
); | ||
expect(getByTestId('span-modal-trigger')).toBeInTheDocument(); | ||
}); | ||
test('renders two code elements in modal when rawSql prop is provided', () => { | ||
const { getByRole, queryByRole, getByTestId } = render( | ||
<HighlightedSql sql={sql} rawSql="SELECT * FORM foo" shrink maxWidth={5} />, | ||
); | ||
expect(queryByRole('dialog')).not.toBeInTheDocument(); | ||
fireEvent.click(getByTestId('span-modal-trigger')); | ||
expect(queryByRole('dialog')).toBeInTheDocument(); | ||
const codeElements = getByRole('dialog').getElementsByTagName('code'); | ||
expect(codeElements.length).toEqual(2); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @captain-hoity-toity for the detail improvement. It was basically migrating existing test block to typescript so I was not able to focus on the test quality.
I'll update your improvement suggestion too!